Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider end stat duplicated in JudgementCounterDisplay #26514

Closed
JacksonChen666 opened this issue Jan 13, 2024 · 1 comment · Fixed by #26540
Closed

Slider end stat duplicated in JudgementCounterDisplay #26514

JacksonChen666 opened this issue Jan 13, 2024 · 1 comment · Fixed by #26540

Comments

@JacksonChen666
Copy link

Type

Game behaviour

Bug description

  1. Put a JudgementCounterDisplay element somewhere
  2. Set display mode to "All"

A "slider end" stat stays at 0 when using "Normal" display mode, and an additional "Slider end" stat is shown when using "All" for display mode.

Screenshots or videos

Version

2024.113.0-lazer

Logs

compressed-logs.zip

@bdach
Copy link
Collaborator

bdach commented Jan 14, 2024

Due to the mess that our judgement system has become there is no easy way to resolve this right now. This is happening because slider tails use either SmallTickHit (classic) or SliderTailHit (non-classic). Both are then labeled as "slider tail" in

case HitResult.SliderTailHit:
case HitResult.SmallTickHit:
return "slider end";

and OsuRuleset declares both hit results as "allowable" for itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants