Pausing gameplay can cause phantom misses

[Locas1000]

Type

Crash to desktop

Bug description

I paused on top of a slider and when I unpaused it counted as a miss but the combo score didn't change. The replay shows a miss but the end screen says the total combo

Screenshots or videos

https://clipchamp.com/watch/IOwL5sv38f7

Version

2023.1231.0-lazer

Logs

compressed-logs.zip

[peppy]

This is going to be due to the rewind happening when pausing/unpausing. We might just want to completely disable that (and the frequency ramp which is the reason for it existing) until things are in a better place.

[frenzibyte]

I cannot seem to reproduce this one at all, not sure what I'm missing.

[peppy]

Try adjusting platform offset to something very high (and also not zero, which is what you have due to macOS). It will be related. I think universal offset may also work.

If that still doesn't work, try increasing the ramp time

osu/osu.Game/Screens/Play/MasterGameplayClockContainer.cs

Line 123 in 6572fa4

this.TransformBindableTo(GameplayClock.ExternalPauseFrequencyAdjust, 0, 200, Easing.Out).OnComplete(_ =>

to absurd levels. It should cause gameplay to skip back on resume.

[frenzibyte]

I still cannot reproduce. I also noticed the following code snippet in OffsetCreationClock:

osu/osu.Game/Screens/Play/OffsetCorrectionClock.cs

Lines 43 to 51 in 343efa1

	private void updateOffset()
	{
	// changing this during the pause transform effect will cause a potentially large offset to be suddenly applied as we approach zero rate.
	if (pauseRateAdjust.Value == 1)
	{
	// we always want to apply the same real-time offset, so it should be adjusted by the difference in playback rate (from realtime) to achieve this.
	base.Offset = Offset * Rate;
	}
	}

Suggesting that the pause frequency adjustment should not affect clock time (when using offset != 0).