Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing: Offset feels incorrect when using (time stretching) rate adjust mods (DT / HT) #24015

Closed
Tracked by #24811 ...
nana123126 opened this issue Jun 23, 2023 · 5 comments
Assignees

Comments

@nana123126
Copy link

nana123126 commented Jun 23, 2023

Type

Game behaviour

Bug description

When I turn on half time, I have to adjust the offset (the object appears earlier) to accurately hit the note. I think I hit the correct note.
The slow the speed, the more feel the object shift.
I don't know if it's because of me or the osulazer. But I found that there is no such issue on osu.
I'm tired of adjusting the offset, so I think I should talk about it.

Screenshots or videos

V42DDX4{9O(~8U6%%TL$Z(E
Playing with "half time" mod enabled and offset adjusted

LCI9L@7D(6 DI$J%7(Q E
Normal play.

(S$%2`EC7S( YUU %SG%F1W
Use the offset when "half time" mod is enabled and play without "half time" mod. (Try to click according to music)

Version

2023.617.0-lazer

Logs

runtime.log

@peppy
Copy link
Member

peppy commented Jun 24, 2023

In stable, we apply an internal offset adjust for DT and HT. This isn't yet implemented in lazer, but by the sounds of it is still required.

@peppy peppy added priority:0 Showstopper. Critical to the next release. area:gameplay labels Jun 24, 2023
@peppy peppy added this to the General usability milestone Jun 24, 2023
@Micha-ohne-el
Copy link
Contributor

My two cents (a player with usually very good accuracy/UR):
In stable, I noticed DT and HT being offset from nomod gameplay, but in lazer I don't notice this.
So for me personally, having no ‘hidden’ offset is better. Maybe it's a case of me being used to lazer now (haven't played stable in years) or it's just user preference. Either way, I think this should be made optional/adjustable.

@monochrome22
Copy link

monochrome22 commented Jun 25, 2023

If it's possible to get used to there being or not being an offset, then it means you should be able to get used to it once it gets added, so it shouldn't be necessary to have it as an option. It would be better to get everyone used to the same thing to avoid splitting player preferences and adding an unnecessary option.

@peppy
Copy link
Member

peppy commented Jun 26, 2023

The offset in stable has been tested across hundreds of players and is required to counter the timeshift / stretch algorithm in bass.

@peppy peppy moved this to Needs implementation in Path to osu!(lazer) ranked play Aug 20, 2023
@peppy peppy removed this from the General usability milestone Aug 20, 2023
@frenzibyte frenzibyte changed the title Unable to accurately hit the target after "half time" Incorrect timing when using rate adjust mod with universal/platform offset applied Aug 25, 2023
@peppy peppy changed the title Incorrect timing when using rate adjust mod with universal/platform offset applied Timing: Offset feels incorrect when using rate adjust mods Sep 14, 2023
@peppy peppy added priority:1 Very important. Feels bad without fix. Affects the majority of users. and removed priority:0 Showstopper. Critical to the next release. labels Sep 14, 2023
@peppy
Copy link
Member

peppy commented Dec 26, 2023

I took feedback on this in discord. The results are, as expected, split between how users play/perceive gameplay. The theory is that users which are more "visual" players are less affected by the audible differences, while those reacting to the music (and the hitsound feedback) generally hit earlier when a time-stretching mod is applied.

The offset applied in stable was a very hidden thing and I'd like to avoid adding it back for now. So the immediate path is to make no change here. I believe that for users struggling with this, we can offer settings profiles which they can apply when playing HT/DT that will adjust their UO accordingly.

For now, I'll convert this to a discussion and we can reconsider down the line.

@peppy peppy removed the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Dec 26, 2023
@ppy ppy locked and limited conversation to collaborators Dec 26, 2023
@peppy peppy converted this issue into discussion #26132 Dec 26, 2023
@peppy peppy changed the title Timing: Offset feels incorrect when using rate adjust mods Timing: Offset feels incorrect when using (time stretching) rate adjust mods (DT / HT) Dec 26, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

4 participants