Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash WinSCP synchronize path issue from quotes in param #240

Closed
Xavron opened this issue Jul 15, 2024 · 1 comment
Closed

Hash WinSCP synchronize path issue from quotes in param #240

Xavron opened this issue Jul 15, 2024 · 1 comment

Comments

@Xavron
Copy link

Xavron commented Jul 15, 2024

Affect both java.io.File and scoped storage.

Test done and confirmed as affecting java.io.File.

Link to issue where it will be fixed by commit and has more info: #205 (comment)

Placing an issue here as it also affects java.io.File, and commit happens to also be fixing it, thus touching that code. This issue will be shortly closed.

Could put it behind a scoped storage block but this one I won't as its not where the issue is.

The problem is the quotes in the param. Remove the quotes and it fixes everything (the quotes wrongly in the path and the double dir too). Maybe its been causing other havoc?

Need to test it for conflicts though to make sure. So far all initial tests good =)

@Xavron
Copy link
Author

Xavron commented Jul 16, 2024

Closing as fixed for java.io.File and scoped storage.

Fixed with commit ab048d5 in pull request #205. Conflict tested on Android 8 and Android 14 via scoped storage and sd card and 2 internal locations. Thousands of files transferred up down and deleted via auto tests with full hash testing on every returned file compared to original. Various command auto tests also run successfully. Briefly tested against java.io.File for confirmation.

@Xavron Xavron closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant