Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHORE: Update node version on CircleCI to 8 #309

Merged
merged 2 commits into from
Nov 14, 2019
Merged

CHORE: Update node version on CircleCI to 8 #309

merged 2 commits into from
Nov 14, 2019

Conversation

abhilashlr
Copy link
Contributor

@abhilashlr abhilashlr commented Nov 13, 2019 •
edited
Loading

This PR addresses #310

@abhilashlr abhilashlr changed the title Update node 8 CHORE: Update node version on CircleCI to 8 Nov 13, 2019
@abhilashlr
Update node 8
1e8c49b 
Test node version

Marking it allowed since release is not yet supported

Adding 3.4 and 3.8 into ember-try
@abhilashlr abhilashlr mentioned this pull request Nov 13, 2019
Closed
sbatson5
sbatson5 reviewed Nov 13, 2019
View reviewed changes
@sbatson5 sbatson5 mentioned this pull request Nov 13, 2019
Closed
@sbatson5 sbatson5 merged commit b68a006 into adopted-ember-addons:master Nov 14, 2019
abhilashlr added a commit to abhilashlr/ember-cli-flash that referenced this pull request Nov 15, 2019
@abhilashlr
CHORE: Update node version on CircleCI to 8 (adopted-ember-addons#309)
5252fc2 
* Update node 8

Test node version

Marking it allowed since release is not yet supported

Adding 3.4 and 3.8 into ember-try

* Removes flag for ember-release
@abhilashlr abhilashlr deleted the circle-ci-node8 branch November 15, 2019 03:28
sbatson5 pushed a commit that referenced this pull request Nov 19, 2019
@abhilashlr
CHORE: Updates ember-try and code ready (#308)
652412b 
* CHORE: Updates ember-try and code ready

Ember 3.8 version update

Codemod run for 3.8.0

* CHORE: Update node version on CircleCI to 8 (#309)

* Update node 8

Test node version

Marking it allowed since release is not yet supported

Adding 3.4 and 3.8 into ember-try

* Removes flag for ember-release

* Experimental commit

* Fix for ember-release
@Turbo87
Copy link
Contributor

Turbo87 commented Dec 1, 2019

the package.json file claims that the addon is compatible with Node 4 (see https://github.com/poteto/ember-cli-flash/blob/master/package.json#L18). shouldn't we run CI on Node 4 then? 🤔

@abhilashlr
Copy link
Contributor Author

the package.json file claims that the addon is compatible with Node 4 (see https://github.com/poteto/ember-cli-flash/blob/master/package.json#L18). shouldn't we run CI on Node 4 then? 🤔

I will have this updated in package.json @Turbo87

@abhilashlr
Copy link
Contributor Author

the package.json file claims that the addon is compatible with Node 4 (see https://github.com/poteto/ember-cli-flash/blob/master/package.json#L18). shouldn't we run CI on Node 4 then? 🤔

Also, this upgrade was done since Travis had been failing for sometime with PRs on this repo. Should we still support Node < 8?

@Turbo87
Copy link
Contributor

Turbo87 commented Dec 6, 2019

Should we still support Node < 8?

No, dropping support for these outdated Node versions is fine, but it should be done in a major version release because it should be considered a breaking change.

@abhilashlr
Copy link
Contributor Author

Should we still support Node < 8?

No, dropping support for these outdated Node versions is fine, but it should be done in a major version release because it should be considered a breaking change.

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbatson5 sbatson5 sbatson5 left review comments

@makepanic makepanic makepanic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhilashlr @Turbo87 @sbatson5 @makepanic