Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guidFor import #299

Merged
merged 1 commit into from
May 16, 2019
Merged

Conversation

villander
Copy link
Contributor

@villander villander commented May 16, 2019

its fixes #298

// this works
import { guidFor } from '../utils/computed';
guidFor(whatever);

// and this works
import * as customComputed from '../utils/computed';
customComputed.guidFor(whatever);

// but this does not work.
import customComputed from '../utils/computed';
customComputed.guidFor(whatever);

This is a case where ember-cli historically allows a non-spec-compliant behavior.

cc: @Dhaulagiri

@Dhaulagiri Dhaulagiri merged commit cb0811e into adopted-ember-addons:master May 16, 2019
@Dhaulagiri
Copy link
Collaborator

Thanks! Will release soon-ish.

@villander
Copy link
Contributor Author

thanks @Dhaulagiri

@Dhaulagiri Dhaulagiri added the bug label May 16, 2019
@Dhaulagiri
Copy link
Collaborator

Released in 1.7.2

@villander
Copy link
Contributor Author

@Dhaulagiri you forget of publish this on npm

@Dhaulagiri
Copy link
Collaborator

Dhaulagiri commented May 21, 2019

@villander sorry about that, it should be actually published now 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken with embroider
2 participants