Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(package): update postcss v6.0.0...7.0.0 (dependencies) #375

Merged
merged 2 commits into from
Aug 4, 2018
Merged

chore(package): update postcss v6.0.0...7.0.0 (dependencies) #375

merged 2 commits into from
Aug 4, 2018

Conversation

damanwiththeplan
Copy link
Contributor

@damanwiththeplan damanwiththeplan commented Jul 19, 2018 •
edited by michael-ciniawsky
Loading

Commit Message Body

BREAKING CHANGE: requires `node >= v6.0.0`

Type

  • Chore

SemVer

  • Breaking Change (:label: Major)

Issues

Checklist

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@coveralls
Copy link

coveralls commented Jul 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 80.233% when pulling bf413ae on patrickabkarian:patch-1 into 5c1c108 on postcss:master.

@michael-ciniawsky michael-ciniawsky changed the title Update package.json chore(package): update postcss v6.0.0...7.0.0 (dependencies) Jul 19, 2018
michael-ciniawsky
michael-ciniawsky requested changes Jul 19, 2018
View reviewed changes
package.json
@@ -7,11 +7,11 @@
"lib"
],
"engines": {
"node": ">= 4"
"node": ">= 5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>= 6

package.json
"standard": "^11.0.0",
"standard-version": "^4.0.0",
"sugarss": "^1.0.0",
"sugarss": "^1.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave it as ^1.0.0 since the ^ will already install the latest semver minor && patch within the v1.x.x range

@michael-ciniawsky michael-ciniawsky added this to the 3.0.0 milestone Jul 19, 2018
@michael-ciniawsky michael-ciniawsky mentioned this pull request Jul 19, 2018
Closed
@michael-ciniawsky
Copy link
Member

⚠️ Do not merge before v2.0.0 branch has been cut

@michael-ciniawsky michael-ciniawsky changed the base branch from master to develop August 4, 2018 04:44
@michael-ciniawsky michael-ciniawsky merged commit 4e7d764 into webpack-contrib:develop Aug 4, 2018
michael-ciniawsky pushed a commit that referenced this pull request Aug 4, 2018
@damanwiththeplan @michael-ciniawsky
chore(package): update postcss v6.0.0...7.0.0 (dependencies) (#375)
96b104e 
BREAKING CHANGE: requires `node >= v6.0.0`
@damanwiththeplan damanwiththeplan deleted the patch-1 branch August 7, 2018 11:32
michael-ciniawsky pushed a commit that referenced this pull request Aug 8, 2018
@damanwiththeplan @michael-ciniawsky
chore(package): update postcss v6.0.0...7.0.0 (dependencies) (#375)
75a977f 
BREAKING CHANGE: requires `node >= v6.0.0`
michael-ciniawsky pushed a commit that referenced this pull request Aug 8, 2018
@damanwiththeplan @michael-ciniawsky
chore(package): update postcss v6.0.0...7.0.0 (dependencies) (#375)
daa0da8 
BREAKING CHANGE: requires `node >= v6.0.0`
@michael-ciniawsky michael-ciniawsky removed this from the 3.0.0 milestone Aug 8, 2018
This was referenced Aug 9, 2018
Merged
Merged
Merged
@dependencies dependencies bot mentioned this pull request Nov 1, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-ciniawsky michael-ciniawsky michael-ciniawsky requested changes

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

Assignees
No one assigned
Labels
scope: postcss semver: major status: approved type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damanwiththeplan @coveralls @michael-ciniawsky