Fix Data explorer tab order for Summary Right layout #4681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarenerd
changed the title
petetronic
approved these changes
Sep 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #3778.
Prior to this PR, Data Explorer rendered the table summary Data Grid first and the table data Data Grid second, regardless of the layout. This meant that tabbing through the Data Explorer always resulted in the table summary Data Grid being the first tab stop and the table data Data Grid being the second tab stop, even when their layout was reversed.
With this PR, Data Explorer now renders the table summary Data Grid and the table data Data Grid in layout order. So, the rendering order is:
Summary Left:
block-beta TableSummary\nDataGrid:5 Splitter:1 TableData\nDataGrid:5Summary Right:
block-beta TableData\nDataGrid:5 Splitter:1 TableSummary\nDataGrid:5Which results in the correct tab stop order for the Summary Right layout.
QA Notes
To test this, switch the Data Explorer layout between Summary Left and Summary Right and note how the tab stop order changes.