-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependencies
entry for which
, which was causing the wrong version of which
to be used, which caused R not to load on some configurations of Windows
#4311
Conversation
which
which was causing the wrong version of which
to be used which caused R not to load on Windows
which
which was causing the wrong version of which
to be used which caused R not to load on Windowsdependencies
entry for which
which was causing the wrong version of which
to be used which caused R not to load on Windows
dependencies
entry for which
which was causing the wrong version of which
to be used which caused R not to load on Windowsdependencies
entry for which
, which was causing the wrong version of which
to be used, which caused R not to load on Windows
dependencies
entry for which
, which was causing the wrong version of which
to be used, which caused R not to load on Windowsdependencies
entry for which
, which was causing the wrong version of which
to be used, which caused R not to load on some configurations of Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So happy we ran this down!
Works fine for me in my Windows VM (where I could never reproduce this), so that's good.
And it just plain makes sense.
extensions/positron-r/package.json
Outdated
"winreg": "^1.2.5", | ||
"which": "^3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it feels like we're keeping these in alphabetical order? In which case we should:
"winreg": "^1.2.5", | |
"which": "^3.0.0" | |
"which": "^3.0.0", | |
"winreg": "^1.2.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot on. Fixed.
@@ -2315,6 +2315,13 @@ which@2.0.2, which@^2.0.1: | |||
dependencies: | |||
isexe "^2.0.0" | |||
|
|||
which@^3.0.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This PR addresses #4280.
This issue was tracked down to the fact that the
positron-r
extension did not have an explicitdependencies
entry for thewhich
package, but it did have adevDependencies
entry for@types/which
("@types/which": "^3.0.0",
).As a result of this, the
positron-r/node_modules
folder containedwhich
2.0.2 (I believe) from:This version of
which
does not support thenothrow
option forasync which
, which we rely on in this code fragment fromextensions/positron-r/src/provider.ts
:Because of this, on some configurations of Windows, an error was being thrown which caused R not to load.
For background on this, see: npm/node-which#80. This was the exact same problem.
QA Notes