Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data explorer: exclusive filters #4375

Open
davidrsch opened this issue Aug 16, 2024 · 2 comments
Open

Data explorer: exclusive filters #4375

davidrsch opened this issue Aug 16, 2024 · 2 comments
Labels
area: data explorer Issues related to Data Explorer category. enhancement New feature or request support

Comments

@davidrsch
Copy link

It could be very handy to have not filters for all available filters. Just like is null-is not null and is equal-is not equal. When filtering text columns could be very handy to have no contains cause you may not know all possible values but do know those you don't want. I see how this can be troublesome enlarging the numbers of filters listed, so I thought that adding a checkbox when for is not(or does not) filtering could help. This checkbox could also be added to the filter bar along with the filter.

@jthomasmock jthomasmock added the area: data explorer Issues related to Data Explorer category. label Aug 16, 2024
@seeM seeM added the enhancement New feature or request label Aug 16, 2024
@jthomasmock jthomasmock added this to the Release Candidate milestone Aug 19, 2024
@jthomasmock
Copy link
Contributor

Thanks for the feature request!

For posterity, here are the filters.

image

We should have a "Does Not Contain" filter.

We acknowledge there are already a few clicks here, so we'd prefer to have discrete buttons over a toggle + button.

@wesm
Copy link
Contributor

wesm commented Sep 9, 2024

Seems like adding "does not contain" right away would be low hanging fruit that we should do regardless of whether we add a negation toggle?

wesm added a commit that referenced this issue Sep 11, 2024
As discussed in #4375, this adds the "does not contain" / "not contains"
string search type to the data explorer protocol and adds a simple
implementation for Python.

https://github.com/user-attachments/assets/dad0863a-eb8d-4794-9eb7-936f24d47a1c

Ark PR: posit-dev/ark#519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: data explorer Issues related to Data Explorer category. enhancement New feature or request support
Projects
None yet
Development

No branches or pull requests

5 participants