-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bokeh support #4118
Comments
It's worth checking if this works in VSCode. If so, we may just need to wire something up properly (probably in the notebook output webview service or positron notebook controllers). |
(To be clear, calling output_notebook() first does allow one to render a bokeh plot inline via the interactive terminal) |
…localhost (#4178) Addresses #4118 Hooks into the new `'show-html-file'` comm path to display html files opened with the `webbrowser` python module in the viewer pane. Previously we overrode the `webbrowser` opening to forward localhost servers, so this just adds a condition to check for html files and do a similar thing. Here's an example of it working on a bokeh plot that previously used to open in an external browser: <img width="1115" alt="image" src="https://github.com/user-attachments/assets/d258ae4e-f8d2-449a-8490-b99bb282aaca"> Rough edges: - Bokeh widget doesn't seem to care about the size of the viewer pane. <!-- Thank you for submitting a pull request. If this is your first pull request you can find information about contributing here: * https://github.com/posit-dev/positron/blob/main/CONTRIBUTING.md We recommend synchronizing your branch with the latest changes in the main branch by either pulling or rebasing. --> <!-- Describe briefly what problem this pull request resolves, or what new feature it introduces. Include screenshots of any new or altered UI. Link to any GitHub issues but avoid "magic" keywords that will automatically close the issue. If there are any details about your approach that are unintuitive or you want to draw attention to, please describe them here. --> ### QA Notes <!-- Add additional information for QA on how to validate the change, paying special attention to the level of risk, adjacent areas that could be affected by the change, and any important contextual information not present in the linked issues. -->
Verified Fixed
Test scenario(s)Verified fixed using original filing criteria. Will keep an open for dialog related functionality with upcoming tickets. Link(s) to TestRail test cases run or created: |
This doesn't seem to work on windows. The sample code results in:
|
A sub-issue of #1924
Currently, bokeh plots don't work as one would hope.
If running plain bokeh plot code: e.g.
The plot shows up, but in an external browser window:
If you try and get clever and use the notebook mode things get even less useful:
The error that appears in the javascript/webview developer console is the helpful:
The text was updated successfully, but these errors were encountered: