Project Wizard: Enter key doesn't work without tabbing past selection of a project type

[testlabauto]

Positron Version: 2024.06.0-50

Steps to reproduce the issue:

1. Start to create a project with the project wizard
2. Select an R or Python project using TAB and arrow keys
3. Hit Enter
4. Note that it won't function without tabbing over to the Next button

What did you expect to happen?

The enter key would immediately work after selecting a project type (when Next becomes active)

Were there any error messages in the output or Developer Tools console?

No

[testlabauto]

Note from Sharon:
If you'd like, we can broaden the issue to all modals since the default accept functionality was generally removed (e.g. it'll impact the New Folder dialog too)

[jonvanausdeln]

Note for QA - If this flow changes (e.g. no need for next button), there are automated tests that will need to be updated.

[sharon-wang]

Another test case: #4203

[petetronic]

Thomas also mentioned Enter was not working for the Missing R Package dialog, my assumption is there's something missing in the base modal components for these cases.

[sharon-wang]

Yes, we disabled the default key Enter behaviour in #3442 as it was causing incorrect behaviour in some modals where pressing Enter would accept and close the modal, however the default button is not always for accepting and closing the modal (e.g. the default button could be a Next or Browse button).

We figured it was more disruptive for the Enter key to accept/close a modal whose default button is not OK (which can cause undefined behaviour and loss of user progress) than for the user to have to click the default button, at least until we add support for the default button action.

[softwarenerd]

This issue is addressed in #4739.

[testlabauto]

Verified Fixed

Positron Version(s) : 2024.09.0-81
OS Version          : OSX

Test scenario(s)

Enter key functions as expected in project wizard

Link(s) to TestRail test cases run or created: