Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Explorer: Rendering glitch when column has 100% missing values #2861

Closed
jmcphers opened this issue Apr 23, 2024 · 2 comments
Closed

Data Explorer: Rendering glitch when column has 100% missing values #2861

jmcphers opened this issue Apr 23, 2024 · 2 comments
Assignees
@softwarenerd
Labels
area: data explorer Issues related to Data Explorer category. bug Something isn't working
Milestone
Release Candidate

Comments

@jmcphers
Copy link
Collaborator

jmcphers commented Apr 23, 2024 •
edited
Loading

Positron Version:

Positron Version: 2024.04.0 (Universal) build 1522
Code - OSS Version: 1.88.0
Commit: 02906e46e1563260ba30ea7acd2d4081cfad7e61
Date: 2024-04-18T03:26:08.743Z
Electron: 28.2.8
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 23.4.0

Steps to reproduce the issue:

Run this Python code:

import pandas as pd
df = pd.DataFrame([[None, None, None]])
%view df

Look at the summary stats:

image

There's still a bit of a bar clipped. Here's a closer look at a higher zoom:

image

What did you expect to happen?

The bar showing 100% missing values should be 100% red.
@jmcphers jmcphers added bug Something isn't working area: data explorer Issues related to Data Explorer category. labels Apr 23, 2024
@jthomasmock jthomasmock added this to the Public Beta 2024 Q2 milestone Apr 29, 2024
@jmcphers jmcphers mentioned this issue Aug 8, 2024
Closed
@softwarenerd softwarenerd self-assigned this Aug 8, 2024
@softwarenerd softwarenerd mentioned this issue Aug 8, 2024
Merged
@softwarenerd
Copy link
Contributor

Addressed in #4295.

wesm pushed a commit that referenced this issue Aug 8, 2024
@softwarenerd
Refine how the ColumnNullPercent component is painted (#4295)
d1012cc 
This PR addresses #2861 and
#4291 by refining how the
`ColumnNullPercent` component is painted.

Now, when the column null percent is 100% or 0%, the graph is painted at
100% red or 0% red:


![image](https://github.com/user-attachments/assets/f469e5f7-4698-4efd-b3d4-74859afe81ec)

When the column null percent is less than 5%, the graph is painted at 5%
so that it registers properly:


![image](https://github.com/user-attachments/assets/20ffe522-3be9-432f-976e-14c5375b4830)

Similarly, when the column null percent is greater than 95%, the graph
is painted at 95% so that it registers properly:


![image](https://github.com/user-attachments/assets/b85ba64f-ee32-4aca-8af2-d93940c18305)

Finally, as can be seen in the screen shots above, the graph is now
clipped to prevent it from bleeding outside its bounds (which was
happening, here's how that used to look):


![image](https://github.com/user-attachments/assets/e1a6a3a0-acf2-413f-b5bd-7275f182f836)
@softwarenerd
Copy link
Contributor

This issue is superseded by #4291 which is larger in scope and is addressed in #4295.

@softwarenerd softwarenerd closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@softwarenerd softwarenerd

Labels
area: data explorer Issues related to Data Explorer category. bug Something isn't working
Projects
None yet
Milestone
Release Candidate
Development

No branches or pull requests
4 participants
@wesm @jmcphers @softwarenerd @jthomasmock