From 598f8b6440d589949077127ffdd684fd5f0d4dfc Mon Sep 17 00:00:00 2001 From: Lionel Henry Date: Thu, 15 Jun 2023 16:27:30 +0200 Subject: [PATCH] Rename to `sleepOnStartup` for consistency --- extensions/jupyter-adapter/package.json | 2 +- extensions/jupyter-adapter/src/JupyterKernel.ts | 8 ++++---- extensions/jupyter-adapter/src/jupyter-adapter.d.ts | 2 +- extensions/positron-r/src/jupyter-adapter.d.ts | 2 +- extensions/positron-r/src/kernel.ts | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/extensions/jupyter-adapter/package.json b/extensions/jupyter-adapter/package.json index 32000c7d6364..b01e4f099695 100644 --- a/extensions/jupyter-adapter/package.json +++ b/extensions/jupyter-adapter/package.json @@ -37,7 +37,7 @@ "default": false, "description": "Run before starting up Jupyter kernel (when supported)" }, - "positron.jupyterAdapter.delayStartup": { + "positron.jupyterAdapter.sleepOnStartup": { "scope": "window", "type": "number", "description": "Sleep for n seconds before starting up Jupyter kernel (when supported)" diff --git a/extensions/jupyter-adapter/src/JupyterKernel.ts b/extensions/jupyter-adapter/src/JupyterKernel.ts index 3e0cdb332d5b..cbbf6511a712 100644 --- a/extensions/jupyter-adapter/src/JupyterKernel.ts +++ b/extensions/jupyter-adapter/src/JupyterKernel.ts @@ -506,14 +506,14 @@ export class JupyterKernel extends EventEmitter implements vscode.Disposable { const config = vscode.workspace.getConfiguration('positron.jupyterAdapter'); const attachOnStartup = config.get('attachOnStartup', false) && this._extra?.attachOnStartup; - const delayStartup = config.get('delayStartup', undefined) && this._extra?.delayStartup; + const sleepOnStartup = config.get('sleepOnStartup', undefined) && this._extra?.sleepOnStartup; if (attachOnStartup) { this._extra!.attachOnStartup!.init(args); } - if (delayStartup) { - const delay = config.get('delayStartup', 0); - this._extra!.delayStartup!.init(args, delay); + if (sleepOnStartup) { + const delay = config.get('sleepOnStartup', 0); + this._extra!.sleepOnStartup!.init(args, delay); } const command = args.join(' '); diff --git a/extensions/jupyter-adapter/src/jupyter-adapter.d.ts b/extensions/jupyter-adapter/src/jupyter-adapter.d.ts index 208cc755ef8b..8825ca593a81 100644 --- a/extensions/jupyter-adapter/src/jupyter-adapter.d.ts +++ b/extensions/jupyter-adapter/src/jupyter-adapter.d.ts @@ -94,7 +94,7 @@ export interface JupyterKernelExtra { init: (args: Array) => void; attach: () => Promise; }; - delayStartup?: { + sleepOnStartup?: { init: (args: Array, delay: number) => void; }; } diff --git a/extensions/positron-r/src/jupyter-adapter.d.ts b/extensions/positron-r/src/jupyter-adapter.d.ts index 208cc755ef8b..8825ca593a81 100644 --- a/extensions/positron-r/src/jupyter-adapter.d.ts +++ b/extensions/positron-r/src/jupyter-adapter.d.ts @@ -94,7 +94,7 @@ export interface JupyterKernelExtra { init: (args: Array) => void; attach: () => Promise; }; - delayStartup?: { + sleepOnStartup?: { init: (args: Array, delay: number) => void; }; } diff --git a/extensions/positron-r/src/kernel.ts b/extensions/positron-r/src/kernel.ts index 975317bdefcd..d67e803df646 100644 --- a/extensions/positron-r/src/kernel.ts +++ b/extensions/positron-r/src/kernel.ts @@ -234,7 +234,7 @@ export function registerArkKernel(ext: vscode.Extension, context: vscode.Ex const extra: JupyterKernelExtra = { attachOnStartup: new ArkAttachOnStartup(), - delayStartup: new ArkDelayStartup(), + sleepOnStartup: new ArkDelayStartup(), }; // Create an adapter for the kernel to fulfill the LanguageRuntime interface.