Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Explorer: Add basic implementation of "not contains" search type #519

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

wesm
Copy link
Contributor

@wesm wesm commented Sep 10, 2024

Ark side of posit-dev/positron#4633. The unit tests here for these filters are a bit janky and don't seem to test correctness so I didn't add a test right way. It might make sense to give them a complete working over.

Copy link
Contributor

@dfalbel dfalbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wesm wesm merged commit 398cfb9 into main Sep 11, 2024
3 checks passed
@wesm wesm deleted the feature/de-not-contains-filter branch September 11, 2024 19:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants