Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

janno contamination consistency ignores NA #270

Closed
stschiff opened this issue Sep 1, 2023 · 2 comments
Closed

janno contamination consistency ignores NA #270

stschiff opened this issue Sep 1, 2023 · 2 comments

Comments

@stschiff
Copy link
Member

stschiff commented Sep 1, 2023

The current implementation complains if NA is in the Contamination column, with no values in the two other required Contamination fields. That is obviously a bug, because the specification makes no semantic difference between an empty string and NA.

@nevrome
Copy link
Member

nevrome commented Sep 1, 2023

Hm... I can not reproduce this. How exactly did you encode NA? Literally with NA or with the correct n/a? Maybe that's already the issue? Or how could I reproduce this behaviour?

Independent of that we should certainly improve the validation for these sets of columns. We already discussed this in #153 and I still think that's the right way to approach this. Also considering semantic changes we may want to apply to the schema (poseidon-framework/poseidon-schema#64).

@stschiff
Copy link
Member Author

stschiff commented Sep 4, 2023

Yeah, very sorry to have wasted your time 🙈, I used NA. Good learning session for me. I'll close this.

@stschiff stschiff closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants