Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-node-termination-handler: Support custom labels #1491

Closed
github-actions bot opened this issue Dec 13, 2021 · 1 comment
Closed

aws-node-termination-handler: Support custom labels #1491

github-actions bot opened this issue Dec 13, 2021 · 1 comment
Labels
area/kubernetes Kubernetes cloud/aws Cloud Provider / Amazon AWS kind/feature Categorizes issue or PR as related to a new feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix

Comments

@github-actions
Copy link
Contributor

aws-node-termination-handler: Support custom labels

aws/aws-node-termination-handler#529

portefaix.xyz/version: v0.25.0

a8r.io/description: A Kubernetes controller for Elastic Load Balancers

a8r.io/owner: aws

a8r.io/bugs: https://github.com/kubernetes-sigs/aws-node-termination-handler/issues

a8r.io/documentation: https://kubernetes-sigs.github.io/aws-node-termination-handler

a8r.io/repository: https://github.com/kubernetes-sigs/aws-node-termination-handler/

a8r.io/support: https://github.com/kubernetes-sigs/aws-node-termination-handler/issues

https://github.com/portefaix/portefaix/blob/ce13ffcf0bfa9a2f4051f6e4a52bed8cd57f1a26/kubernetes/base/kube-system/aws-node-terminaison-handler/aws-node-termination-handler.yaml#L39

# Copyright (C) 2021 Nicolas Lamirault <nicolas.lamirault@gmail.com>
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

---
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: aws-node-termination-handler
  namespace: kube-system
spec:
  chart:
    spec:
      # renovate: registryUrl=https://aws.github.io/eks-charts
      chart: aws-node-termination-handler
      version: 0.16.0
      sourceRef:
        kind: HelmRepository
        name: eks
        namespace: flux-system
  interval: 5m0s
  releaseName: aws-node-termination-handler
  targetNamespace: kube-system
  install:
    crds: CreateReplace
  upgrade:
    crds: CreateReplace
  values:
    # TODO: aws-node-termination-handler: Support custom labels
    # labels: kind/feature, priority/low, lifecycle/frozen, area/kubernetes, cloud/aws
    # https://github.com/aws/aws-node-termination-handler/pull/529

    # customLabels:
    #   portefaix.xyz/version: v0.25.0

    # additionalAnnotations:
    #   a8r.io/description: A Kubernetes controller for Elastic Load Balancers
    #   a8r.io/owner: aws
    #   a8r.io/bugs: https://github.com/kubernetes-sigs/aws-node-termination-handler/issues
    #   a8r.io/documentation: https://kubernetes-sigs.github.io/aws-node-termination-handler
    #   a8r.io/repository: https://github.com/kubernetes-sigs/aws-node-termination-handler/
    #   a8r.io/support: https://github.com/kubernetes-sigs/aws-node-termination-handler/issues

    jsonLogging: true
    logLevel: "info"

    nodeSelector:
      lifecycle: self-managed-spot

    serviceAccount:
      name: aws-node-termination-handler

    # TODO: how monitoring
    # enablePrometheusServer: true
    # podMonitor:
    #   enabled: true
    #   labels:
    #     monitoring: portefaix

12c586b89524a3c25f78a73a9556041f132d0cfe

@github-actions github-actions bot added area/kubernetes Kubernetes cloud/aws Cloud Provider / Amazon AWS kind/feature Categorizes issue or PR as related to a new feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix todo labels Dec 13, 2021
@stale
Copy link

stale bot commented Feb 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 11, 2022
@stale stale bot closed this as completed Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes Kubernetes cloud/aws Cloud Provider / Amazon AWS kind/feature Categorizes issue or PR as related to a new feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix
Projects
None yet
Development

No branches or pull requests

0 participants