-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zerox~ #298
Comments
looks like it only counts positive to negative or negative to positive (meaning > 0 to = 0 and =0 to > 0 aren't counted but < 0 to = 0 and = 0 to < 0 are). I suppose this is fine for most signals, but signals strictly >= 0 (such as [phasor~] but NOT [phasor~] * -1) would register as 0 frequency. I suppose this could be technically correct(?) since these signals don't cross zero, but it depends on what Max does. Also, this goes by block (which seems to be what Max does as well according to the documentation) so that could be another explanation for poor frequency estimate (which zero crossing isn't that great for anyways...) |
I think so. For what I remember, Max has a better estimation output, this is why I should have opened this issue, but I'll double check (not a high priority right now though). |
frequency estimate is bad... block shouldn't affetct count?
The text was updated successfully, but these errors were encountered: