Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Species QC for StrAga #881

Closed
11 tasks
jeromekelleher opened this issue Apr 9, 2021 · 9 comments
Closed
11 tasks

Species QC for StrAga #881

jeromekelleher opened this issue Apr 9, 2021 · 9 comments
Assignees

Comments

@jeromekelleher
Copy link
Member

PR for new species: #854

If you volunteer to QC this species, please use the checklist below.
While this list is intended to be comprehensive, it may not be exhaustive.
Where relevant, the QC reviewer should identify that parameter values match
those given in the linked citation(s).

  • Recombination rate.
    • This might be genome-wide, or per-chromosome. Both are fine.
    • Check there's a comment describing where it came from, and/or how calculated.
    • From a publication? Check the value(s) match the publication.
    • Calculated somehow? Average over a recombination map? Redo the calculation.
  • Mutation rate.
    • This might be genome-wide, or per-chromosome. Both are fine.
    • Check there's a comment describing where it came from, and/or how calculated.
    • From a publication? Check the value(s) match the publication.
    • Calculated somehow? Redo the calculation.
  • Recombination map (if present).
    • Does it match the assembly? Liftover is fine, if clearly stated.
    • Is the description/long_description a good summary of how the map was created?
  • Population size.
  • Generation time.

For each citation, check:

  • Doi link.
  • Is publication a preprint? Is there a peer-reviewed publication instead?
  • Is the year correct.
  • Is the author correct (spelling, accents/ligatures/etc.)

Citations are required for:

  • Genome reference assembly.
  • Mutation rate.
  • Recombination rate.
  • Recombination map(s) (if relevant).
  • Population size.
  • Generation time.
@igronau
Copy link
Contributor

igronau commented Dec 14, 2021

I will start QC-ing this species

@vitorpavinato
Copy link
Contributor

Do we need to parametrize this species with "mean gene conversion rate and gene conversion tract length" as mentioned here #1106?

@petrelharp
Copy link
Contributor

Hi, @igronau @vitorpavinato - are you planning to do this or should someone else do it?

@vitorpavinato
Copy link
Contributor

vitorpavinato commented May 10, 2022

Hi @petrelharp. I wasn't sure about adding gene conversion parameterization when I was doing it, so I looked at the parameters. I guess I can't do this QC anymore.

@petrelharp
Copy link
Contributor

Ah, ok, thanks. About the GC rates: currently they're commented out, so don't need QC'ing, but the GC stuff will be merged in soon, so: maybe? (And: I'm not sure what you mean by "I guess I can't do this", but if you want to continue here we'd be happy to have you, but that's probably not what you mean.)

@igronau
Copy link
Contributor

igronau commented May 14, 2022

I didn't really dive into this one yet, so I prefer if someone else will QC this one.

@vitorpavinato
Copy link
Contributor

Hi @petrelharp. I am going to QC this species. But I guess someone else should also do it?

@petrelharp
Copy link
Contributor

But I guess someone else should also do it?

We only need one person to QC - what do you mean?

@petrelharp
Copy link
Contributor

Closed in #1251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants