Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all linked accounts in user drop-down, with “Unlink” button next to GitHub account #1644

Open
outoftime opened this issue Feb 20, 2019 · 2 comments

Comments

@outoftime
Copy link
Contributor

outoftime commented Feb 20, 2019

Originally from #1622, and followup to #1637:

We want to show enough information about the linked GitHub account to allow the student to make an informed decision about whether it’s the correct one. So, add a component to the logged-in user drop-down that shows the user’s GitHub avatar and display name, along with an Unlink button. For consistency, we’ll just show the same information about the linked Google account, although there will be no Unlink option here because Google is the primary authentication provider for Popcode.

@pwjablonski
Copy link
Contributor

Hey @outoftime - I was playing around with this last night. It took some time to land on the layout that I think makes sense. As for adding the information for the linked Google Account, it seems a bit redundent to add the Google info in the drop down since most of that data already exisiting in the CurrentUserButton. Atlernatively we can remove that info from CurrentUserButton and add it as another MenuItem. Let me know what you think.

OLD
Screen Shot 2019-04-03 at 12 41 52 PM
Screen Shot 2019-04-03 at 12 50 32 PM

UPDATED
Screen Shot 2019-04-03 at 12 20 41 PM
Screen Shot 2019-04-03 at 12 20 11 PM

@outoftime
Copy link
Contributor Author

I was playing around with this last night. It took some time to land on the layout that I think makes sense.

I like it!

As for adding the information for the linked Google Account, it seems a bit redundent to add the Google info in the drop down since most of that data already exisiting in the CurrentUserButton.

Yeah, I see what you’re saying here—I think I was thinking about it too much like a programmer (must have consistency!) rather than from a UX standpoint. From the user standpoint, your Google account isn’t “linked”—it’s just how you log in to Popcode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants