From 514853c7b497152fba3b8220433451af6bf5125c Mon Sep 17 00:00:00 2001 From: rishishah-multidots Date: Tue, 22 Oct 2024 14:44:41 +0530 Subject: [PATCH 1/2] made changes as per the feedback --- lib/compat/wordpress-6.8/block-comments.php | 11 ----------- .../test/__snapshots__/build.js.snap | 18 ++++++++++++++++++ 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/lib/compat/wordpress-6.8/block-comments.php b/lib/compat/wordpress-6.8/block-comments.php index df205599223929..ff9f03b69aa1c3 100644 --- a/lib/compat/wordpress-6.8/block-comments.php +++ b/lib/compat/wordpress-6.8/block-comments.php @@ -1,15 +1,4 @@ array('dependencies' => array('lodash', 'wp-blob'), 'version' => 'e1840d27f0719ffa42d3'), 'fileB.js' => array('dependencies' => array('wp-token-list'), 'version' => '1e60e007d6496c9b46cf')); +" +`; + exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dependency-graph\` should produce expected output: Asset file 'main.asset.php' should match snapshot 1`] = ` " array('wp-interactivity'), 'version' => '82601013091064d44360'); " @@ -423,6 +428,19 @@ exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dependency-g ] `; +exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dependency-graph\` should produce expected output: External modules should match snapshot 2`] = ` +[ + { + "externalType": "window", + "request": [ + "wp", + "interactivity", + ], + "userRequest": "@wordpress/interactivity", + }, +] +`; + exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dynamic-dependency-graph\` should produce expected output: Asset file 'main.asset.php' should match snapshot 1`] = ` " array('wp-interactivity'), 'version' => '162f4d352c99e6c37be1'); " From 4b59a869b0babe6ef981f628faff430c68910b5e Mon Sep 17 00:00:00 2001 From: rishishah-multidots Date: Tue, 22 Oct 2024 14:46:53 +0530 Subject: [PATCH 2/2] made changes as per the feedback --- .../test/__snapshots__/build.js.snap | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/packages/dependency-extraction-webpack-plugin/test/__snapshots__/build.js.snap b/packages/dependency-extraction-webpack-plugin/test/__snapshots__/build.js.snap index 90e724ea55c9be..8ea40b00d7c2d1 100644 --- a/packages/dependency-extraction-webpack-plugin/test/__snapshots__/build.js.snap +++ b/packages/dependency-extraction-webpack-plugin/test/__snapshots__/build.js.snap @@ -405,11 +405,6 @@ exports[`DependencyExtractionWebpackPlugin scripts Webpack \`combine-assets\` sh ] `; -exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dependency-graph\` should produce expected output: Asset file 'assets.php' should match snapshot 1`] = ` -" array('dependencies' => array('lodash', 'wp-blob'), 'version' => 'e1840d27f0719ffa42d3'), 'fileB.js' => array('dependencies' => array('wp-token-list'), 'version' => '1e60e007d6496c9b46cf')); -" -`; - exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dependency-graph\` should produce expected output: Asset file 'main.asset.php' should match snapshot 1`] = ` " array('wp-interactivity'), 'version' => '82601013091064d44360'); " @@ -428,19 +423,6 @@ exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dependency-g ] `; -exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dependency-graph\` should produce expected output: External modules should match snapshot 2`] = ` -[ - { - "externalType": "window", - "request": [ - "wp", - "interactivity", - ], - "userRequest": "@wordpress/interactivity", - }, -] -`; - exports[`DependencyExtractionWebpackPlugin scripts Webpack \`cyclic-dynamic-dependency-graph\` should produce expected output: Asset file 'main.asset.php' should match snapshot 1`] = ` " array('wp-interactivity'), 'version' => '162f4d352c99e6c37be1'); "