New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if-expression seems to be different between Check and mfachecker #54

Closed

michielbdejong opened this issue Apr 4, 2023 · 4 comments

Assignees

Member

michielbdejong commented Apr 4, 2023

Looks like nextcloud/server#37195 (comment) is right,
in https://github.com/nextcloud/server/pull/37195/files#diff-324119d2db6f3d5a6d7546558dd8011e16e04683d83c4d29d69ff5f250f353d1R62
we are only checking for SAML while https://github.com/pondersource/nextcloud-mfa-awareness/blob/7011a58/mfachecker/lib/Controller/PageController.php#L33-L53 checks for SAML, GSS, and local MFA.

michielbdejong assigned mrvahedi68

michielbdejong mentioned this issue

Add "MFA Verified" check to workflowengine nextcloud/server#37195

Closed

Contributor

mrvahedi68 commented Apr 4, 2023

Yes, I'll fix this.

Contributor

mrvahedi68 commented Apr 5, 2023 •

edited

Loading

Where does the $user variable fill?
@michielbdejong @navid-dada
https://github.com/pondersource/nextcloud-mfa-awareness/blob/7011a58/mfachecker/lib/Controller/PageController.php#LL52

navid-shokri commented Apr 5, 2023 •

edited

Loading

oops, you can fill it by using UserManager to retrieve the user using the given user Id. ℹ️
you can find the usage approach there:
https://github.com/pondersource/server/blob/master/apps/federatedfilesharing/lib/Controller/RequestHandlerController.php

Member Author

michielbdejong commented Jun 26, 2023

This issue is both 'open' and 'done'

mrvahedi68 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment