Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Implement shareInfoToResourceInfo #226

Closed
michielbdejong opened this issue Nov 1, 2022 · 6 comments
Closed

Implement shareInfoToResourceInfo #226

michielbdejong opened this issue Nov 1, 2022 · 6 comments

Comments

@michielbdejong
Copy link
Member

https://github.com/pondersource/nc-sciencemesh/blob/f48c933/lib/Controller/RevaController.php#L243

2022-11-01 12:28:50.264 INF ../../reva/pkg/ocm/share/manager/nextcloud/nextcloud.go:212 > am.do response 201 {"todo":"compile this info from various database tables"} pid=7 pkg=rgrpc traceid=94d2b8b1b559653b398275880d470c35
2022-11-01 12:28:50.634 DBG ../../reva/internal/grpc/interceptors/log/log.go:66 > unary code=OK end="01/Nov/2022:12:28:50 +0000" from=tcp://127.0.0.1:52202 pid=7 pkg=rgrpc start="01/Nov/2022:12:28:50 +0000" time_ns=575027101 traceid=94d2b8b1b559653b398275880d470c35 uri=/cs3.sharing.ocm.v1beta1.OcmAPI/CreateOCMShare user-agent=grpc-go/1.49.0
2022-11-01 12:28:50.635 DBG ../../reva/internal/grpc/interceptors/log/log.go:66 > unary code=OK end="01/Nov/2022:12:28:50 +0000" from=tcp://127.0.0.1:51590 pid=7 pkg=rgrpc start="01/Nov/2022:12:28:50 +0000" time_ns=577984245 traceid=7abf12e35115a51d921c3a8f05530c10 uri=/cs3.gateway.v1beta1.GatewayAPI/CreateOCMShare user-agent=grpc-go/1.49.0
2022-11-01 12:28:50.635 WRN ../../reva/internal/http/services/ocmd/ocmd.go:132 > request not handled pid=7 pkg=rhttp traceid=95b31bb50c5d0314952a08966acd66ca
2022-11-01 12:28:50.636 WRN ../../reva/internal/http/interceptors/log/log.go:112 > http end="01/Nov/2022:12:28:50 +0000" host=192.168.208.4 method=POST pid=7 pkg=rhttp proto=HTTP/2.0 size=0 start="01/Nov/2022:12:28:49 +0000" status=404 time_ns=1391885727 traceid=95b31bb50c5d0314952a08966acd66ca uri=/ocm/send url=/ocm/send
@michielbdejong
Copy link
Member Author

Info available from the share:
node.path /einstein/files/welcome.txt
nodeType file
shareType 1000
shareOwner einstein
sharedWith marie@revanc2.docker

@michielbdejong
Copy link
Member Author

I think what Reva is expecting is just an opaque ID for the share that was created
https://github.com/cs3org/reva/blob/72e36b8/pkg/ocm/share/manager/nextcloud/nextcloud.go#L317

@michielbdejong
Copy link
Member Author

Indeed it ends up as the remote_id in nc2.docker:

MariaDB [nextcloud]> select * from oc_share_external;
+----+--------+------------+-------------------------+-----------------------------------------------------------+-------------+----------+--------------+----------+-------+------------------------------------------+----------------------------------+----------+
| id | parent | share_type | remote                  | remote_id                                                 | share_token | password | name         | owner    | user  | mountpoint                               | mountpoint_hash                  | accepted |
+----+--------+------------+-------------------------+-----------------------------------------------------------+-------------+----------+--------------+----------+-------+------------------------------------------+----------------------------------+----------+
|  1 |     -1 |       1000 | https://revanc1.docker/ | {"todo":"compile this info from various database tables"} | yJRVQGPyUK  |          | /welcome.txt | einstein | marie | {{TemporaryMountPointName#/welcome.txt}} | 32021e94fecfcd644f9a5666263732f5 |        0 |
+----+--------+------------+-------------------------+-----------------------------------------------------------+-------------+----------+--------------+----------+-------+------------------------------------------+----------------------------------+----------+
1 row in set (0.001 sec)

@michielbdejong
Copy link
Member Author

The share gets created in oc_share on the sending side, but I'm not sure at which point.
So I don't know where to get its id.
https://github.com/nextcloud/server/blob/06627c800c45672d57a255f494c5d47efd160aff/lib/private/Share20/Manager.php#L1781

@michielbdejong
Copy link
Member Author

So SAH-createShare calls RHC-createShare
and then later SSP-create triggers addition to the database
I don't actually see a call coming from Reva? I would expect Reva to create the share in its share backend.
Will test what happens when we create the share from reva-cli!

@michielbdejong
Copy link
Member Author

I think this was done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant