Check for null when using UriResolverExtensionFileReader to read wasm module #1317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Wasm wrapper dev tries to invoke an interface in their wrapper, an error isn't thrown in the
wasm-js
package. Instead of returning a UInt8Array containing a Wasm pacakge, the_getWasmModule
method in WasmWrapper.ts returnsnull
. Thenull
value is passed around until a null pointer exception is thrown when trying to callindexOf
on it in theindexOfArray
method inutils.ts
in theasyncify-js
package.The null value arrises because the
UriResolverExtensionFileReader
in theuri-resolver-extensions
package wants to return a UInt8Array or an error. However, thegetFile
method of the uri resolver interface returnsBytes | null
. All of the uri resolver implementations return null on failure. So we need to check that the retrieved file data is not null.