Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bind): map of array weren't generating invalid bindings #924

Merged
merged 23 commits into from
Jul 7, 2022
Merged

fix(bind): map of array weren't generating invalid bindings #924

merged 23 commits into from
Jul 7, 2022

Conversation

Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented Jun 16, 2022 •
edited
Loading

@Niraj-Kamdar Niraj-Kamdar changed the base branch from prealpha-dev to nk/cli-workflow June 20, 2022 08:17
@Niraj-Kamdar Niraj-Kamdar marked this pull request as draft June 20, 2022 08:17
@dOrgJelli dOrgJelli changed the base branch from nk/cli-workflow to prealpha-dev June 23, 2022 18:47
@Niraj-Kamdar Niraj-Kamdar marked this pull request as ready for review July 4, 2022 14:54
@Niraj-Kamdar Niraj-Kamdar requested a review from namesty as a code owner July 4, 2022 14:54
@dOrgJelli dOrgJelli changed the base branch from prealpha-dev to origin-dev July 6, 2022 09:04
dOrgJelli
dOrgJelli approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@dOrgJelli dOrgJelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 @Niraj-Kamdar

@dOrgJelli dOrgJelli merged commit f03c6b9 into origin-dev Jul 7, 2022
@dOrgJelli dOrgJelli mentioned this pull request Jul 7, 2022
Merged
@dOrgJelli dOrgJelli deleted the nk/fix-map-binding branch April 10, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@krisbitney krisbitney Awaiting requested review from krisbitney

@nerfZael nerfZael Awaiting requested review from nerfZael

@namesty namesty Awaiting requested review from namesty namesty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Niraj-Kamdar @dOrgJelli