-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Rust tests in wrap-rust template #1874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since in rust you would normally create the tests
folder for integration tests (for unit you would do the tests in the same file); what do you think about moving this e2e file to it/module.rs
rather than having:
|_tests/
|_e2e.rs
|_types/
we would have:
|_tests/
|_it/
|_module.rs
|_types/
this is more idiomatic imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Co-authored-by: Cesar Brazon <cesarbrazon10@gmail.com>
This PR replaces the JS e2e tests in the wrap-rust template with Rust tests. The Rust app bindings are generated and used for the e2e tests to provide a nice UX.
It also adds the Rust app bindings to the CLI, which hadn't been done yet, so codegen works as expected.