feat: add wrap-abi-bindgen support + upgrade js client to v0.11 #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abi-bindgen-wraps # Conflicts: # packages/schema/bind/package.json
… failing due to spacing
Closed
…p in different PR)
krisbitney
requested review from
krisbitney,
namesty,
nerfZael,
Niraj-Kamdar and
cbrzn
as code owners
…abi-bindgen-wraps # Conflicts: # packages/cli/src/lib/docgen/docusaurus/index.ts # packages/cli/src/lib/docgen/jsdoc/index.ts # packages/cli/src/lib/docgen/schema/index.ts # packages/test-cases/cases/cli/docgen/002-custom-config/config.ts # packages/test-cases/cases/cli/docgen/004-app/expected/docs/Logger_enums.md # packages/test-cases/cases/cli/docgen/004-app/expected/docs/Logger_module.md
…abi-bindgen-wraps
dOrgJelli
changed the title
…ewest polywrap client
dOrgJelli
commented
Jul 10, 2023
| const result = await client.invoke<Output>({ | ||
| uri, | ||
| method: "generateBindings", | ||
| args: (args as unknown) as Record<string, unknown>, |
There was a problem hiding this comment.
Unrelated: Is this casting really required? If so I think we should fix this because it isn't a very good developer experience.
There was a problem hiding this comment.
Yeah, it's required when using statically typed args objects. TypeScript complains without the cast because args is of type Record<string, unknown> | Uint8Array | undefined.
…abi-bindgen-wraps # Conflicts: # packages/cli/package.json # packages/cli/src/lib/project/PolywrapProject.ts # packages/cli/src/lib/project/manifests/polywrap/languages.ts # packages/schema/bind/package.json # packages/schema/bind/src/__tests__/test-cases.spec.ts # packages/schema/bind/src/bindings/index.ts # packages/schema/bind/src/types.ts # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kris: This PR integrates
wrap-abi-bindgen, which replaces the current bindings generation with wrap-based bindings.See https://github.com/polywrap/wrap-abi-bindgen
A separate PR will add
wrap-rustwrap-based bindings.