Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming rectSize: CGFloat Height of the loader view #9

Open
waltermvp opened this issue Jul 20, 2016 · 1 comment
Open

Renaming rectSize: CGFloat Height of the loader view #9

waltermvp opened this issue Jul 20, 2016 · 1 comment

Comments

@waltermvp
Copy link

Great framework, it's awesome thank you for sharing. One improvement I would like to suggest is to either rename rectSize to height or actually make it a CGSize. I think making is a CGSize would be more work since it may alter the dimensions, but it should be renamed to height since it can be a little misleading. I'd be happy to make a PR.
@polqf
Copy link
Owner

polqf commented Jul 29, 2016

Yep, totally agree with you @waltermvp. That legacy things... 😅
Feel free to open a PR!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waltermvp @polqf