Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svg-feedback CSS path and test server path handling #149

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

mentatbot[bot]
Copy link
Contributor

@mentatbot mentatbot bot commented Jan 17, 2025

This PR fixes two issues:

  1. Corrects the CSS file path in svg-feedback/index.html to properly reference the stylesheet
  2. Improves the test server path handling to correctly serve both HTML and asset files

The changes resolve the HTML test failures for the svg-feedback component that were introduced in PR #148.


Precommit Logs: 11f4abd ✅0fe14e3 ✅

🤖 See my steps and track the cost of the PR here

mentatbot bot and others added 30 commits January 16, 2025 23:13
Created a new React app for the prompt guessing game that will:
- Generate creative prompts using text.pollinations.ai
- Create images from prompts using image.pollinations.ai
- Let users guess the prompts and provide feedback

Next steps:
1. Integrate with text.pollinations.ai for prompt generation
2. Integrate with image.pollinations.ai for image generation
3. Implement prompt similarity checking for guess evaluation

Closes # 140

Mentat precommits passed. Log: https://mentat.ai/log/da1bbadf-deed-4d43-b60e-4fdf03101e21
- Added utility functions for:
  - Generating creative prompts using text.pollinations.ai
  - Creating images from prompts using image.pollinations.ai
  - Evaluating guess similarity
- Enhanced UI with loading and error states
- Added disabled states for inputs during loading
- Improved feedback system for user guesses
- Added loading animation and error styling

Closes # 140

Mentat precommits passed. Log: https://mentat.ai/log/81a96ae5-98dc-4628-985c-a96846c045de
- Added clear instructions for players
- Implemented hint system after 5 attempts
- Show actual prompt after successful guess
- Added game won state to prevent further guesses
- Improved UI feedback and styling
- Added loading and disabled states for better UX

Closes # 140

Mentat precommits passed. Log: https://mentat.ai/log/10c53bb0-aa10-4fdf-9153-ba6aff1b73bc
- Added proper Vite configuration
- Fixed directory structure to match Vite requirements
- Added missing index.css file
- Updated build settings
- Successfully building to dist directory

The build is now working correctly and generating the necessary files.

Mentat precommits passed. Log: https://mentat.ai/log/549d3bf4-9953-43bc-8d8a-e879e2a81697
This PR fixes two issues:
1. Corrects the CSS file path in svg-feedback/index.html to properly reference the stylesheet
2. Improves the test server path handling to correctly serve both HTML and asset files

The changes resolve the HTML test failures for the svg-feedback component that were introduced in PR # 148.

Mentat precommits passed. Log: https://mentat.ai/log/25bf79fc-caeb-4c0d-b63b-c69d2561293b
@mentatbot mentatbot bot requested a review from voodoohop January 17, 2025 15:16
Copy link
Contributor

🚀 PR Preview deployed!

Preview URL: https://pollinations.github.io/hive/pr-149/

1 similar comment
Copy link
Contributor

🚀 PR Preview deployed!

Preview URL: https://pollinations.github.io/hive/pr-149/

Copy link
Contributor

Testing .mentat

Testing ai-chat

Testing static HTML app: ai-chat

Testing graphics-editor

Testing static HTML app: graphics-editor

❌ HTML tests failed for graphics-editor

Testing llm-feedback

Testing static HTML app: llm-feedback

Testing millionaire-game

Testing static HTML app: millionaire-game

❌ HTML tests failed for millionaire-game

Testing placeholder-generator

Testing Node.js app: placeholder-generator

Installing dependencies



added 273 packages, and audited 274 packages in 8s

108 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.

ℹ️ No tests found

Building



> placeholder-generator@0.0.0 build
> vite build

�[36mvite v5.4.11 �[32mbuilding for production...�[36m�[39m
transforming...
�[32m✓�[39m 32 modules transformed.
rendering chunks...
computing gzip size...
�[2mdist/�[22m�[32mindex.html                 �[39m�[1m�[2m  0.45 kB�[22m�[1m�[22m�[2m │ gzip:  0.28 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mindex-Xy5EDiQ3.css  �[39m�[1m�[2m  1.25 kB�[22m�[1m�[22m�[2m │ gzip:  0.61 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mindex-BAcusHwb.js   �[39m�[1m�[2m144.97 kB�[22m�[1m�[22m�[2m │ gzip: 46.73 kB�[22m
�[32m✓ built in 795ms�[39m


Testing pollinations-image-show

Testing Node.js app: pollinations-image-show

Installing dependencies



added 314 packages, and audited 315 packages in 12s

118 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities


ℹ️ No tests found

Building



> pollinations-image-show@0.0.0 build
> vite build

�[36mvite v6.0.7 �[32mbuilding for production...�[36m�[39m
transforming...
�[32m✓�[39m 969 modules transformed.
rendering chunks...
computing gzip size...
�[2mdist/�[22m�[32mindex.html                 �[39m�[1m�[2m  0.46 kB�[22m�[1m�[22m�[2m │ gzip:   0.29 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mindex-Ck1XBn8h.css  �[39m�[1m�[2m  0.56 kB�[22m�[1m�[22m�[2m │ gzip:   0.32 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mindex-COrGKCAO.js   �[39m�[1m�[2m311.91 kB�[22m�[1m�[22m�[2m │ gzip: 104.05 kB�[22m
�[32m✓ built in 2.58s�[39m


Testing prompt-guessing-game

Testing Node.js app: prompt-guessing-game

Installing dependencies



added 61 packages, and audited 62 packages in 2s

7 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities


ℹ️ No tests found

Building



> prompt-guessing-game@0.1.0 build
> vite build

�[36mvite v5.4.11 �[32mbuilding for production...�[36m�[39m
transforming...
�[32m✓�[39m 33 modules transformed.
rendering chunks...
computing gzip size...
�[2mdist/�[22m�[32mindex.html                 �[39m�[1m�[2m  0.46 kB�[22m�[1m�[22m�[2m │ gzip:  0.29 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mindex-Dcj2S7H_.css  �[39m�[1m�[2m  1.71 kB�[22m�[1m�[22m�[2m │ gzip:  0.76 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mindex-DycsOj9-.js   �[39m�[1m�[2m146.36 kB�[22m�[1m�[22m�[2m │ gzip: 47.33 kB�[22m
�[32m✓ built in 820ms�[39m


Testing svg-feedback

Testing static HTML app: svg-feedback

Testing tarot-reader

Testing Node.js app: tarot-reader

Installing dependencies



added 324 packages, and audited 325 packages in 3s

155 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities


ℹ️ No tests found

Building



> tarot-reader@0.0.0 build
> vite build

�[36mvite v6.0.7 �[32mbuilding for production...�[36m�[39m
transforming...
�[32m✓�[39m 34 modules transformed.
rendering chunks...
computing gzip size...
�[2mdist/�[22m�[32mindex.html                 �[39m�[1m�[2m  0.56 kB�[22m�[1m�[22m�[2m │ gzip:  0.33 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mindex-tTF554dA.css  �[39m�[1m�[2m  2.48 kB�[22m�[1m�[22m�[2m │ gzip:  1.03 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mindex-BxXiSpNq.js   �[39m�[1m�[2m149.43 kB�[22m�[1m�[22m�[2m │ gzip: 48.71 kB�[22m
�[32m✓ built in 884ms�[39m


Copy link
Contributor Author

mentatbot bot commented Jan 17, 2025

Hi @github-actions[bot]! You need to be added as a user to interact with me. Please ask @voodoohop to add you on the settings page.

2 similar comments
Copy link
Contributor Author

mentatbot bot commented Jan 17, 2025

Hi @github-actions[bot]! You need to be added as a user to interact with me. Please ask @voodoohop to add you on the settings page.

Copy link
Contributor Author

mentatbot bot commented Jan 17, 2025

Hi @github-actions[bot]! You need to be added as a user to interact with me. Please ask @voodoohop to add you on the settings page.

This PR fixes path issues in multiple components:
1. svg-feedback: Fixed CSS file path and improved test server path handling
2. graphics-editor: Fixed paths to style.css and main.js
3. millionaire-game: Fixed paths to styles.css and script.js

The changes ensure that all static assets are properly served during testing and deployment.

Mentat precommits passed. Log: https://mentat.ai/log/1d44f098-f7a9-4ba7-9fd2-69d505a049d2
Copy link

gru-agent bot commented Jan 17, 2025

TestGru: The source file has been modified. Please add a comment @gru-agent under the changed file to notify the TestGru to rewrite the test code.

Copy link
Contributor Author

mentatbot bot commented Jan 17, 2025

Hi @gru-agent[bot]! You need to be added as a user to interact with me. Please ask @voodoohop to add you on the settings page.

Copy link
Contributor

🚀 PR Preview deployed!

Preview URL: https://pollinations.github.io/hive/pr-149/

1 similar comment
Copy link
Contributor

🚀 PR Preview deployed!

Preview URL: https://pollinations.github.io/hive/pr-149/

Copy link
Contributor Author

mentatbot bot commented Jan 17, 2025

Hi @github-actions[bot]! You need to be added as a user to interact with me. Please ask @voodoohop to add you on the settings page.

1 similar comment
Copy link
Contributor Author

mentatbot bot commented Jan 17, 2025

Hi @github-actions[bot]! You need to be added as a user to interact with me. Please ask @voodoohop to add you on the settings page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant