Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: polkadot pool migration #1710

Merged
merged 2 commits into from
Feb 28, 2025
Merged

feat: polkadot pool migration #1710

merged 2 commits into from
Feb 28, 2025

Conversation

Nick-1979
Copy link
Member

@Nick-1979 Nick-1979 commented Feb 27, 2025

Summary by CodeRabbit

  • New Features
    • Introduced pool migration support enabling governance voting with staked funds on Kusama and Polkadot.
    • Announced an upcoming UI redesign for an enhanced PolkaGate experience.
    • Expanded nomination pool support to include additional network participation on Polkadot.

@Nick-1979 Nick-1979 requested a review from AMIRKHANEF February 27, 2025 22:28
@Nick-1979 Nick-1979 self-assigned this Feb 27, 2025
Copy link
Contributor

coderabbitai bot commented Feb 27, 2025

Walkthrough

A new news entry for version 0.36.0 has been added to the PolkaGate popup, detailing pool migration support and an upcoming UI redesign. In addition, the constant defining migrated nomination pool chains has been updated to include the Polkadot genesis hash, ensuring that the extension correctly reflects the supported chains.

Changes

File Change Summary
packages/.../popup/home/news.ts Added a new news entry for version 0.36.0 with notes on pool migration support and an upcoming PolkaGate UI redesign.
packages/.../util/constants.tsx Updated MIGRATED_NOMINATION_POOLS_CHAINS to include POLKADOT_GENESIS_HASH, reordering the array to [KUSAMA_GENESIS_HASH, POLKADOT_GENESIS_HASH, WESTEND_GENESIS_HASH].

Suggested reviewers

  • AMIRKHANEF

Poem

I'm a rabbit with a cheerful beat,
Hopping through changes, oh so sweet.
New news blooms like spring in May,
With pools and chains leading the way.
Leaping high with each code treat 🐇🎉.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2d40ac and 5b4aebe.

📒 Files selected for processing (2)
  • packages/extension-polkagate/src/popup/home/news.ts (1 hunks)
  • packages/extension-polkagate/src/util/constants.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/extension-polkagate/src/popup/home/news.ts (1)

12-18: LGTM: News entry for version 0.36.0 added correctly

The news entry correctly announces the extension of pool migration support to Polkadot (previously only available for Kusama in v0.35.2) and maintains the notification about the upcoming UI redesign.

packages/extension-polkagate/src/util/constants.tsx (1)

64-64: LGTM: Pool migration support extended to Polkadot

The addition of POLKADOT_GENESIS_HASH to the MIGRATED_NOMINATION_POOLS_CHAINS array properly implements the feature announced in the news entry. This change enables pool migration support for Polkadot, allowing users to vote on governance using their staked funds in Polkadot pools.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Nick-1979 Nick-1979 merged commit 1cbeb7f into main Feb 28, 2025
8 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 28, 2025
# [0.36.0](v0.35.2...v0.36.0) (2025-02-28)

### Features

* polkadot pool migration ([#1710](#1710)) ([1cbeb7f](1cbeb7f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant