Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support minimumPeriod of 0 #5826

Closed
bkchr opened this issue Mar 18, 2024 · 6 comments · Fixed by #5827
Closed

Support minimumPeriod of 0 #5826

bkchr opened this issue Mar 18, 2024 · 6 comments · Fixed by #5827

Comments

@bkchr
Copy link

bkchr commented Mar 18, 2024

With the switch to async backing, parachains will set a minimumPeriod of 0. (Not all, but some).

This currently breaks transaction signing here:

api.consts.timestamp?.minimumPeriod.muln(2) ||

We should check that if minimumPeriod is 0 and then just also use the fallback duration. On top of that we should use SlotDuration from Aura: paritytech/polkadot-sdk#3732 as we use ExpectedBlockTime from Babe.

@bkchr
Copy link
Author

bkchr commented Mar 18, 2024

@TarikGul could we get a quick fix for this?

@TarikGul
Copy link
Member

Just woke up :), @pepoviola - Thanks for the PR. Going to check it all right now!

@TarikGul
Copy link
Member

rel: polkadot-js/apps#9970

@TarikGul
Copy link
Member

Once #5827 goes in we will do a patch release.

@TarikGul
Copy link
Member

Released in 10.12.3

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants