Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually benchmark pallet_xcm::execute for all runtimes #436

Closed
franciscoaguirre opened this issue Aug 15, 2024 · 2 comments · Fixed by #433
Closed

Actually benchmark pallet_xcm::execute for all runtimes #436

franciscoaguirre opened this issue Aug 15, 2024 · 2 comments · Fixed by #433

Comments

@franciscoaguirre
Copy link
Contributor

franciscoaguirre commented Aug 15, 2024

We removed a filter to allow arbitrary XCM execution in the runtimes, but if you actually try to call pallet_xcm::execute you'll get an error saying you exceed max weight.
This is because pallet_xcm::execute has max weight.
This was done to disallow it, now we should benchmark it again.

This is the case for most runtimes in the repo.

@bkontur bkontur mentioned this issue Aug 15, 2024
5 tasks
@bkontur
Copy link
Contributor

bkontur commented Aug 15, 2024

@franciscoaguirre yes, you're right, exactly, I saw this when I did fresh weights comparision today: #433 - all are regenerated (just kusama is missing, I will push in few hours)

@franciscoaguirre
Copy link
Contributor Author

My bad, didn't see that PR 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants