Refactor pending transactions #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sorpaas just a reminder Substrate's |
|
Closinf in favor of #466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need for using the custom
Mutexto handle pending transactions and the service background task that mantains it. Instead makes use of the transaction graph interface to get ethereum transactions from thereadyandfuturequeues.Pros
Uses substrate native Api.
Cons
Additional access to the runtime to filter the ethereum Calls.
Overall I think is worth it and the right way to do it.
Uses paritytech/substrate@dab7d56 - @sorpaas this needs to be in substrate's
frontierbranch in order for it to work. Once is there we can remove this block and get ready for merge it.