Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime storage best practices - Verify First Write Last Requires Additional Info Since Polkadot-v0.9.25 #1215

Closed
2 tasks done
timurguvenkaya opened this issue Jul 2, 2022 · 1 comment
Labels
new content 💡✍️ New Devhub content required.

Comments

@timurguvenkaya
Copy link

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Content request

Section: https://docs.substrate.io/main-docs/build/runtime-storage/ (Verify First, Update Last)

In substrate polkadot-v0.9.25 branch (https://github.com/paritytech/substrate/tree/polkadot-v0.9.25) #[transactional] macro got deprecated since it is now default behavior (paritytech/substrate#11546 & paritytech/substrate#11431). So now, even if verification happens after storage update, the state won't persist. It will get reverted on Err. Hence, it makes sense to update that section according to new updates. It is still best practice to follow, but it needs updated information.

Are you willing to help with this request?

Yes!

@timurguvenkaya timurguvenkaya added the new content 💡✍️ New Devhub content required. label Jul 2, 2022
@lisa-parity
Copy link
Contributor

@timurguvenkaya, information about transactional storage added to the documentation:
https://docs.substrate.io/build/runtime-storage/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new content 💡✍️ New Devhub content required.
Projects
None yet
Development

No branches or pull requests

2 participants