refactor(rust): Move cast from polars-arrow to polars-compute #19967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
nameexhaustion
commented
Nov 25, 2024
| ]; | ||
| let array = Utf8Array::<i64>::from_slice(values); | ||
|
|
||
| let out = utf8_to_utf8view(&array); | ||
| // Ensure we hit the multiple buffers part. | ||
| assert_eq!(out.buffers().len(), 6); | ||
| assert_eq!(out.data_buffers().len(), 4); |
There was a problem hiding this comment.
this runs under cfg(test) which makes the OffsetType an i8
not sure how we ended up with 6 buffers before - I've left some working out above in comments
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19967 +/- ##
==========================================
- Coverage 79.46% 79.46% -0.01%
==========================================
Files 1555 1556 +1
Lines 216322 216339 +17
Branches 2456 2456
==========================================
Hits 171911 171911
- Misses 43853 43870 +17
Partials 558 558 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa,
orlp and
coastalwhite
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be moved first before we can move the gather kernels