perf: Cache path resolving of scan functions
#17616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
|
Yeah, got the same isslue with hive partitioning. First one who knows what it is shares. ;) (afk atm) I think the mutex is better here as the read time is super short. |
stinodego
force-pushed
the
scan-cache-expansion
branch
from
a85ece7 to
ec90d1d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17616 +/- ##
==========================================
- Coverage 80.69% 80.68% -0.02%
==========================================
Files 1484 1484
Lines 195421 195453 +32
Branches 2782 2782
==========================================
+ Hits 157695 157700 +5
- Misses 37214 37241 +27
Partials 512 512 ☔ View full report in Codecov by Sentry. |
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
reviewed
Jul 15, 2024
ritchie46
reviewed
Jul 15, 2024
| } => expand_paths(&lock.0, file_options.glob, cloud_options.as_ref())?, | ||
| #[cfg(feature = "json")] | ||
| FileScan::NDJson { .. } => expand_paths(&lock.0, file_options.glob, None)?, | ||
| FileScan::Anonymous { .. } => lock.0.clone(), // Anonymous scans are already expanded. |
There was a problem hiding this comment.
Suggested change
| FileScan::Anonymous { .. } => lock.0.clone(), // Anonymous scans are already expanded. | |
| FileScan::Anonymous { .. } => unreachable!(), // Invariant: Anonymous scans are already expanded. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17584
Changes
DslPlanafter resolving paths. This avoids re-resolving the paths upon repeatedcollectcalls on the same LazyFrame.