fix: Don't unwrap send attempt to oneshot channel

[nameexhaustion]

Closes #17565
Closes #16915

[stinodego]

Thanks - let's hope this addresses #17565 . If not, I will re-open the issue and we can take another look.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (daf2e49) to head (2276553).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17566   +/-   ##
=======================================
  Coverage   80.48%   80.49%           
=======================================
  Files        1483     1483           
  Lines      195118   195194   +76     
  Branches     2778     2778           
=======================================
+ Hits       157039   157117   +78     
+ Misses      37568    37566    -2     
  Partials      511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kszlim]

@nameexhaustion what happens in the failure case? Does it need to be retried or something? I have personally encountered this issue before too in #16915

[nameexhaustion]

@nameexhaustion what happens in the failure case? Does it need to be retried or something? I have personally encountered this issue before too in #16915

No, we don't retry - the channel receiver / async task is cancelled, so the result is not needed. I don't believe there to be any other case.