Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Update GroupBy.__iter__ docstring to match new behavior #17383

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 3, 2024

Closes #17376

This should have been updated in #16793 - my mistake!

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (663fe4c) to head (ddad1da).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17383      +/-   ##
==========================================
- Coverage   80.72%   80.72%   -0.01%     
==========================================
  Files        1475     1475              
  Lines      193383   193383              
  Branches     2760     2760              
==========================================
- Hits       156113   156110       -3     
- Misses      36760    36763       +3     
  Partials      510      510              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 60fa8db into main Jul 3, 2024
16 checks passed
@stinodego stinodego deleted the gb-iter-docs branch July 3, 2024 06:32
@elliott-omosheye
Copy link

@stinodego
Copy link
Member Author

I believe the partition_by docs are also still wrong #16793 (files)

You are correct. PR incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix doc of GroupBy.__iter__
2 participants