fix: Don't null on oob in list.get for column index
#17276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17276 +/- ##
==========================================
- Coverage 80.89% 80.85% -0.05%
==========================================
Files 1470 1471 +1
Lines 192689 192855 +166
Branches 2750 2750
==========================================
+ Hits 155876 155925 +49
- Misses 36305 36422 +117
Partials 508 508 ☔ View full report in Codecov by Sentry. |
mcrumiller
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
mcrumiller
commented
Jun 28, 2024
| _ => Ok(None), | ||
| }) | ||
| .collect::<Result<IdxCa, _>>()? | ||
| }; |
There was a problem hiding this comment.
@ritchie46 there's probably a better way to do this without duplicated code, maybe using something like iter::repeat(true) in place of the validity map, but my grasp of polars iterators is not up to snuff.
There was a problem hiding this comment.
I think its fine fo rnow. Thanks!
2 tasks
ritchie46
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #17262, closes #17252. Fixes the column idx case.
Added more test coverage.