Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Add elementwise select and with_columns to new streaming engine #17185

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jun 25, 2024

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 78 lines in your changes missing coverage. Please review.

Project coverage is 80.80%. Comparing base (6fe7efe) to head (8ad7534).
Report is 29 commits behind head on main.

Files Patch % Lines
crates/polars-stream/src/nodes/select.rs 0.00% 54 Missing ⚠️
crates/polars-stream/src/nodes/in_memory_sink.rs 0.00% 10 Missing ⚠️
crates/polars-stream/src/physical_plan/to_graph.rs 0.00% 9 Missing ⚠️
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 2 Missing ⚠️
...src/executors/sinks/group_by/generic/hash_table.rs 0.00% 1 Missing ⚠️
.../polars-pipe/src/executors/sinks/group_by/utils.rs 0.00% 1 Missing ⚠️
...tes/polars-stream/src/utils/in_memory_linearize.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17185      +/-   ##
==========================================
- Coverage   80.89%   80.80%   -0.10%     
==========================================
  Files        1456     1466      +10     
  Lines      191355   192081     +726     
  Branches     2742     2745       +3     
==========================================
+ Hits       154801   155213     +412     
- Misses      36045    36363     +318     
+ Partials      509      505       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp requested a review from alexander-beedie as a code owner June 26, 2024 11:00
Copy link

codspeed-hq bot commented Jun 26, 2024

CodSpeed Performance Report

Merging #17185 will degrade performances by 26.89%

Comparing orlp:new-streaming-elementwise (8ad7534) with main (df989de)

Summary

❌ 1 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main orlp:new-streaming-elementwise Change
test_groupby_h2oai_q1 2.1 ms 2.9 ms -26.89%

@ritchie46 ritchie46 merged commit 49f5ef5 into pola-rs:main Jun 26, 2024
21 checks passed
@stinodego stinodego changed the title feat: add elementwise select and with_columns to new streaming engine refactor(rust): add elementwise select and with_columns to new streaming engine Jun 28, 2024
@stinodego stinodego removed python Related to Python Polars enhancement New feature or an improvement of an existing feature labels Jun 28, 2024
@github-actions github-actions bot added the internal An internal refactor or improvement label Jun 28, 2024
@stinodego stinodego changed the title refactor(rust): add elementwise select and with_columns to new streaming engine refactor(rust): Add elementwise select and with_columns to new streaming engine Jun 28, 2024
@c-peters c-peters added the accepted Ready for implementation label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants