Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect window std for chunked series #17110

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jun 21, 2024

Fixes #17102

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jun 21, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review June 21, 2024 13:33
@@ -855,7 +855,7 @@ where
},
GroupsProxy::Slice { groups, .. } => {
if _use_rolling_kernels(groups, self.chunks()) {
let arr = self.downcast_iter().next().unwrap();
let arr = ca.downcast_iter().next().unwrap();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, that was silly.

@ritchie46 ritchie46 merged commit 0c1274f into pola-rs:main Jun 22, 2024
28 checks passed
@nameexhaustion nameexhaustion deleted the window-std branch June 22, 2024 11:35
@nameexhaustion nameexhaustion self-assigned this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windowed std does not work correctly (non-deterministic, incorrect values)
2 participants