Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(python): Pin optional NumPy dependency to < 2.0.0 for now #17060

Merged
merged 1 commit into from
Jun 19, 2024
Merged

build(python): Pin optional NumPy dependency to < 2.0.0 for now #17060

merged 1 commit into from
Jun 19, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 19, 2024 •
edited
Loading

Ref #16998

I should have done this earlier - apologies. I had misjudged the implications here.

To be clear:

  • This will make sure pip install polars[numpy] gets you a compatible version.
  • If you have NumPy 2.0 installed, you can still pip install polars without problems. Polars works with NumPy 2.0 with certain limitations (see linked issue).

@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars labels Jun 19, 2024
@stinodego stinodego marked this pull request as ready for review June 19, 2024 08:55
@stinodego stinodego merged commit d265f35 into main Jun 19, 2024
15 checks passed
@stinodego stinodego deleted the pin-numpy-dep branch June 19, 2024 09:37
@c-peters c-peters added the accepted Ready for implementation label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees

@stinodego stinodego

Labels
accepted Ready for implementation build Changes that affect the build system or external dependencies python Related to Python Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stinodego @c-peters