Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not parse hive partitions from user provided base directory path #17055

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jun 19, 2024

Before:

scan_parquet("data/a=1/")
shape: (5, 3)
┌─────┬───┬─────┐
│ a   ┆ … ┆ x   │
│ --- ┆   ┆ --- │
│ i64 ┆   ┆ i32 │
╞═════╪═══╪═════╡
│ 1   ┆ … ┆ 1   │
│ 1   ┆ … ┆ 1   │
│ 1   ┆ … ┆ 1   │
│ 1   ┆ … ┆ 1   │
│ 1   ┆ … ┆ 1   │
└─────┴───┴─────┘

After:

scan_parquet("data/a=1/")
┌───┬─────┐
│ … ┆ x   │
│   ┆ --- │
│   ┆ i32 │
╞═══╪═════╡
│ … ┆ 1   │
│ … ┆ 1   │
│ … ┆ 1   │
│ … ┆ 1   │
│ … ┆ 1   │
└───┴─────┘

@github-actions github-actions bot added breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 19, 2024
@nameexhaustion nameexhaustion changed the title feat!: Do not parse hive partitions from user provided directory path feat!: Do not parse hive partitions from user provided directory/glob path Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (14dd2ca) to head (67fcf94).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17055      +/-   ##
==========================================
+ Coverage   80.90%   80.91%   +0.01%     
==========================================
  Files        1455     1455              
  Lines      190954   190961       +7     
  Branches     2723     2723              
==========================================
+ Hits       154494   154525      +31     
+ Misses      35956    35932      -24     
  Partials      504      504              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 4d15fd4 into pola-rs:main Jun 19, 2024
27 checks passed
@nameexhaustion nameexhaustion deleted the hive-directory branch June 19, 2024 07:14
@nameexhaustion nameexhaustion self-assigned this Jun 24, 2024
@c-peters c-peters added the accepted Ready for implementation label Jun 24, 2024
@nameexhaustion nameexhaustion changed the title feat!: Do not parse hive partitions from user provided directory/glob path feat!: Do not parse hive partitions from user provided base directory path Jun 24, 2024
@stinodego stinodego removed the breaking Change that breaks backwards compatibility label Jun 24, 2024
@stinodego stinodego changed the title feat!: Do not parse hive partitions from user provided base directory path feat: Do not parse hive partitions from user provided base directory path Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants