fix(python): Update some Series dunder method type signatures
#17053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli and
reswqa
as code owners
alexander-beedie
changed the title
Series dunder method type signaturesSeries dunder method type signatures
alexander-beedie
force-pushed
the
series-dunder-method-typing
branch
from
651558f to
c423bc0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17053 +/- ##
==========================================
- Coverage 80.94% 80.87% -0.08%
==========================================
Files 1449 1455 +6
Lines 190705 190954 +249
Branches 2723 2723
==========================================
+ Hits 154372 154434 +62
- Misses 35829 36016 +187
Partials 504 504 ☔ View full report in Codecov by Sentry. |
stinodego
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17048.
The correct typing for "other" here is
Any(it can legitimately be almost anything, and we handle the case that it is not a Series internally; fixing this also lets us ditch a few "type: ignore" directives in the unit tests).