Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix failing file cache test in CI #17014

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

nameexhaustion
Copy link
Collaborator

I think the eviction task ran instantly - to fix this we won't check if the paths were created, instead we just check the file is successfully read.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (c19c377) to head (28957d0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17014      +/-   ##
==========================================
- Coverage   81.04%   81.02%   -0.02%     
==========================================
  Files        1446     1446              
  Lines      190422   190422              
  Branches     2708     2708              
==========================================
- Hits       154331   154293      -38     
- Misses      35594    35632      +38     
  Partials      497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 4c1c67c into pola-rs:main Jun 17, 2024
13 checks passed
@nameexhaustion nameexhaustion deleted the file-cache branch June 22, 2024 11:34
@c-peters c-peters added the accepted Ready for implementation label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants