Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise on invalid arithmetic shapes #16986

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix: Raise on invalid arithmetic shapes #16986

merged 1 commit into from
Jun 16, 2024

Conversation

ritchie46
Copy link
Member

fixes #16978

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (12fb43a) to head (24fb425).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16986      +/-   ##
==========================================
- Coverage   81.03%   81.02%   -0.01%     
==========================================
  Files        1446     1446              
  Lines      190415   190425      +10     
  Branches     2709     2709              
==========================================
- Hits       154294   154293       -1     
- Misses      35624    35635      +11     
  Partials      497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 16, 2024

CodSpeed Performance Report

Merging #16986 will improve performances by 22.58%

Comparing err (24fb425) with main (12fb43a)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main err Change
test_groupby_h2oai_q1 2.8 ms 2.3 ms +22.58%

@ritchie46
Copy link
Member Author

@nameexhaustion the benchmark fails due to something ttl related.

@ritchie46 ritchie46 merged commit 4ce4c6b into main Jun 16, 2024
26 of 27 checks passed
@ritchie46 ritchie46 deleted the err branch June 16, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cannot apply operation on arrays of different lengths" panic occurs when add two Series have defferent length
1 participant