test: Fix file cache verbose logging leakage during pytest #16984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I played around a bit, I think what happens is pytest joins on the N workers it spawns together at the end, and some workers finish running tests earlier. This and combined with that pytest I think only silences test output during execution of a test, so the workers that have finished (and are getting joined on) no longer have silenced stdout/stderr, the printing from the background task then gets displayed after the background task runs, as POLARS_VERBOSE was set to true during the test execution
I can seemingly confirm because the more I increase the worker count, the more messages get logged.
This is fixed by not caching the
config::verbose
value, as it gets unset after the test finishes.