fix: Don't pushdown predicates in cross join if the refer to both tables

[ritchie46]

fixes #16956

[codspeed-hq]

CodSpeed Performance Report

Merging #16983 will degrade performances by 17.51%

_{Comparing cross (a0f3bd6) with main (1effc24)}

Summary

❌ 1 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	cross	Change
❌	test_groupby_h2oai_q1	2.1 ms	2.6 ms	-17.51%

[daBlesr]

Hi @ritchie46 thank you picking this up this quickly. In the test I see you use a full join instead of a cross join, is this intentional? If I use a full join, the problem does not show up.

[ritchie46]

Whoops. No, it isn't. I will update the test. The fix still is valid. ;)