Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix edge case in DataFrame constructor data orientation inference #16975

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 16, 2024

I found an edge case where the input [[1]] would be interpreted row-wise when it could be interpreted column-wise. Shouldn't really have user impact, as the resulting dataframe is the same.

We'll get rid of this logic anyway, but I have to fix this to properly deprecate it, otherwise we get false positives.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (9af88f1) to head (c7f3f85).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16975      +/-   ##
==========================================
+ Coverage   81.03%   81.04%   +0.01%     
==========================================
  Files        1445     1445              
  Lines      190157   190318     +161     
  Branches     2712     2709       -3     
==========================================
+ Hits       154091   154244     +153     
- Misses      35567    35577      +10     
+ Partials      499      497       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review June 16, 2024 03:28
@stinodego stinodego merged commit 9f097ea into main Jun 16, 2024
17 checks passed
@stinodego stinodego deleted the fix-row-orient branch June 16, 2024 03:29
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants