Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Standardised additional SQL interface errors #16829

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jun 9, 2024

  • (fix) SQL parser errors should be mapped to the new SQLInterface error (not ComputeError).
  • (misc) Standardised use of "can't" vs "cannot" in error messages.
  • (refactor) Consolidated some test files.

@alexander-beedie alexander-beedie changed the title Sql interface errors feat: Standardised some SQL interface errors Jun 9, 2024
@alexander-beedie alexander-beedie changed the title feat: Standardised some SQL interface errors feat: Standardised additional SQL interface errors Jun 9, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 9, 2024
@alexander-beedie alexander-beedie added the A-sql Area: Polars SQL functionality label Jun 9, 2024
@alexander-beedie alexander-beedie changed the title feat: Standardised additional SQL interface errors fix: Standardised additional SQL interface errors Jun 9, 2024
@alexander-beedie alexander-beedie removed the enhancement New feature or an improvement of an existing feature label Jun 9, 2024
@github-actions github-actions bot added the fix Bug fix label Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.39%. Comparing base (f548041) to head (c109a92).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-sql/src/functions.rs 11.11% 8 Missing ⚠️
crates/polars-sql/src/context.rs 66.66% 1 Missing ⚠️
crates/polars-sql/src/sql_expr.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16829   +/-   ##
=======================================
  Coverage   81.38%   81.39%           
=======================================
  Files        1425     1425           
  Lines      187610   187615    +5     
  Branches     2697     2697           
=======================================
+ Hits       152695   152700    +5     
  Misses      34420    34420           
  Partials      495      495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 8934698 into pola-rs:main Jun 10, 2024
35 checks passed
@alexander-beedie alexander-beedie deleted the sql-interface-errors branch June 10, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql Area: Polars SQL functionality fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants